Skip to content

missing BOOST_FALLTHROUGH in a few cases#1073

Merged
grisumbras merged 1 commit intoboostorg:developfrom
RoyBellingan:BOOST_FALLTHROUGH
Feb 24, 2025
Merged

missing BOOST_FALLTHROUGH in a few cases#1073
grisumbras merged 1 commit intoboostorg:developfrom
RoyBellingan:BOOST_FALLTHROUGH

Conversation

@RoyBellingan
Copy link

@RoyBellingan RoyBellingan commented Feb 15, 2025

After seeing a few test failing for #1071 I added a few more check in my local build, and those 3 popped out

@cppalliance-bot
Copy link

cppalliance-bot commented Feb 15, 2025

An automated preview of the documentation is available at https://1073.json.prtest2.cppalliance.org/libs/json/doc/html/index.html

@codecov
Copy link

codecov bot commented Feb 15, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.70%. Comparing base (c02d872) to head (e3531d3).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1073   +/-   ##
========================================
  Coverage    93.70%   93.70%           
========================================
  Files           91       91           
  Lines         9139     9139           
========================================
  Hits          8564     8564           
  Misses         575      575
Files with missing lines Coverage Δ
include/boost/json/basic_parser_impl.hpp 98.50% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c02d872...e3531d3. Read the comment docs.

@cppalliance-bot
Copy link

cppalliance-bot commented Feb 15, 2025

pullrequest
Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/1073/pullrequest.html

grisumbras
grisumbras requested changes Feb 19, 2025
View reviewed changes
@cppalliance-bot
Copy link

cppalliance-bot commented Feb 19, 2025

An automated preview of the documentation is available at https://1073.json.prtest2.cppalliance.org/libs/json/doc/html/index.html

@cppalliance-bot
Copy link

cppalliance-bot commented Feb 19, 2025

pullrequest
Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/1073/pullrequest.html

@grisumbras grisumbras merged commit e3531d3 into boostorg:develop Feb 24, 2025
3 checks passed
@grisumbras
Copy link
Member

grisumbras commented Feb 24, 2025

Thank you for your contribution.

@RoyBellingan
Copy link
Author

RoyBellingan commented Feb 24, 2025

Each Journey begin with one step!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@grisumbras grisumbras grisumbras requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@RoyBellingan @cppalliance-bot @grisumbras